Re: [PATCH -next] coccinelle: platform_get_irq: Fix parse error

From: Markus Elfring
Date: Fri Sep 06 2019 - 03:41:27 EST


>> I proposed something also during the development for this SmPL script.
>> https://lkml.org/lkml/2019/7/24/274
>> https://lore.kernel.org/r/c98b8f50-1adf-ea95-a91c-ec451e9fefe2@xxxxxx/
>
> Markus,
>
> This is not the first time you have suggested to someone to do something
> that was simply incorrect.

We come along different application expectations.


> Please actually test your suggestions before proposing them.

I dare to express also âquestionableâ development ideas.


>> Should disjunctions eventually work in the semantic patch language also together with
>> comparison operators?
>> https://github.com/coccinelle/coccinelle/issues/40
>
> No.

Can a similar effect be achieved by using a SmPL constraint for
a metavariable of the type âbinary operatorâ?
https://github.com/coccinelle/coccinelle/blob/b4509f6e7fb06d5616bb19dd5a110b203fd0e566/docs/manual/cocci_syntax.tex#L266


>> Will any additional software adjustments be taken into account?
>
> No.

I imagine that this view can change over time according to remaining feature requests.

Regards,
Markus