Re: [Xen-devel] [PATCH] ARM: xen: unexport HYPERVISOR_platform_op function

From: Andrew Cooper
Date: Fri Sep 06 2019 - 11:55:37 EST


On 06/09/2019 16:39, Arnd Bergmann wrote:
> HYPERVISOR_platform_op() is an inline function and should not
> be exported. Since commit 15bfc2348d54 ("modpost: check for
> static EXPORT_SYMBOL* functions"), this causes a warning:
>
> WARNING: "HYPERVISOR_platform_op" [vmlinux] is a static EXPORT_SYMBOL_GPL
>
> Remove the extraneous export.
>
> Fixes: 15bfc2348d54 ("modpost: check for static EXPORT_SYMBOL* functions")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Something is wonky. That symbol is (/ really ought to be) in the
hypercall page and most definitely not inline.

Which tree is that changeset from? I can't find the SHA.

I hate to open a separate can of worms, but why are they tagged GPL?Â
The Xen hypercall ABI, like the Linux syscall ABI, are specifically not
GPL. Xen has as something very similar to (and probably derived from)
the Linux-syscall-note exception.

~Andrew