Re: [PATCH] samples: watch_queue: add HEADERS_INSTALL dependency

[Arnd Bergmann]

On Sat, Sep 7, 2019 at 4:07 AM Masahiro Yamada
<yamada.masahiro@xxxxxxxxxxxxx> wrote:
>
> samples/watch_queue/Makefile specifies the header search path
> -I$(objtree)/usr/include, which is probaby needed to include
> <linux/watch_queue.h> etc.
>
> To make it work properly, add "depends on HEADERS_INSTALL" so that
> headers are installed into $(objtree)/usr/include before building
> this sample.
>
> Fixes: 7141642ed120 ("Add sample notification program")
> Reported-by: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>

Tested-by: Arnd Bergmann <arnd@xxxxxxxx>

> Arnd reported a build error:
> https://lkml.org/lkml/2019/9/6/665
>
> Missing "depends on HEADERS_INSTALL" is the only reason
> I have in my mind.
>
> If it still fails to build, I do not know why.

It works, thanks for the fix!

       Arnd