Re: [PATCH] Fixed most indent issues in tty_io.c
From: Joe Perches
Date: Sat Sep 07 2019 - 16:01:16 EST
On Sat, 2019-09-07 at 21:51 +0200, Sandro Volery wrote:
> > On 7 Sep 2019, at 21:27, Joe Perches <joe@xxxxxxxxxxx> wrote:
[]
> > As long as git diff -w shows no difference and a compiled
> > object comparison before and after the change shows no
> > difference, I think it's fine.
>
> My thoughts, too. I didn't feel comfortable arguing as a newbie tho
> so I'll see what I can do once I get home.
If you do that, it's important to mention both elements in
the commit message:
1: git diff -w shows no difference
2: pre and post compilation objects are identical
It is also good to verify that allyesconfig and defconfig
objects with the minimal CONFIG_ required for compilation
are also identical.
Whitespace only changes should only change horizontal
spacing and should not have vertical line changes.