Re: [PATCH 2/5] clk: qcom: apcs-msm8916: get parent clock names from DT
From: Stephen Boyd
Date: Mon Sep 09 2019 - 06:24:29 EST
Quoting Jorge Ramirez-Ortiz (2019-08-26 09:45:07)
> @@ -61,6 +63,16 @@ static int qcom_apcs_msm8916_clk_probe(struct platform_device *pdev)
> if (!a53cc)
> return -ENOMEM;
>
> + /* legacy bindings only defined the pll parent clock (index = 0) with no
Another nitpick: This is wrong multi-line comment style. SHould be a
bare /* on this line.
> + * name; when both of the parents are specified in the bindings, the
> + * pll is the second one (index = 1).
> + */