Re: [PATCH 1/2] export.h: remove defined(__KERNEL__)

[Nicolas Pitre]

On Mon, 9 Sep 2019, Masahiro Yamada wrote:

> Hi Nicolas,
> 
> On Mon, Sep 9, 2019 at 10:48 PM Nicolas Pitre <nico@xxxxxxxxxxx> wrote:
> >
> > On Mon, 9 Sep 2019, Masahiro Yamada wrote:
> >
> > > This line was touched by commit f235541699bc ("export.h: allow for
> > > per-symbol configurable EXPORT_SYMBOL()"), but the commit log did
> > > not explain why.
> > >
> > > CONFIG_TRIM_UNUSED_KSYMS works for me without defined(__KERNEL__).
> >
> > I'm pretty sure it was needed back then so not to interfere with users
> > of this file. My fault for not documenting it.
> 
> Hmm, I did not see a problem in my quick build test.
> 
> Do you remember which file was causing the problem?

If you build commit 7ec925701f5f with CONFIG_TRIM_UNUSED_KSYMS=y and the 
defined(__KERNEL__) test removed then you'll get:

  HOSTCC  scripts/mod/modpost.o
In file included from scripts/mod/modpost.c:24:
scripts/mod/../../include/linux/export.h:81:10: fatal error: linux/kconfig.h: No such file or directory


Nicolas