Re: [PATCH] driver core: ensure a device has valid node id in device_add()
From: Michal Hocko
Date: Tue Sep 10 2019 - 03:13:53 EST
On Tue 10-09-19 14:43:32, Yunsheng Lin wrote:
> On 2019/9/9 17:53, Greg KH wrote:
[...]
> > But as we do not know the node, can we cause more harm by randomly
> > picking one (i.e. putting it all in node 0)?
> If we do not pick node 0 for device with invalid node, then caller need
> to check the node id and pick one, and currently different callers
> does a different checking:
Could you be more specific about who those callers are why do they need
the node id for? Because the page allocator can handle that as already
pointed out in my other email. Who else does really have to know about
the node apart the allocator?
--
Michal Hocko
SUSE Labs