Re: [PATCH v3 2/2] PTP: add support for one-shot output

From: Richard Cochran
Date: Tue Sep 10 2019 - 11:48:02 EST


On Mon, Sep 09, 2019 at 10:59:40AM +0300, Felipe Balbi wrote:

> /*
> * Bits of the ptp_perout_request.flags field:
> */
> -#define PTP_PEROUT_VALID_FLAGS (~0)
> -
> +#define PTP_PEROUT_ONE_SHOT (1<<0)
> +#define PTP_PEROUT_VALID_FLAGS (~PTP_PEROUT_ONE_SHOT)

Here also, the bitwise not is backwards. ^

Thanks,
Richard