Re: [PATCH] ARM: Add support for Realtek SOC

[Masahiro Yamada]

On Wed, Sep 11, 2019 at 5:17 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> On Wed, Sep 11, 2019 at 9:46 AM James Tai[æåå] <james.tai@xxxxxxxxxxx> wrote:
> > > Subject: Re: [PATCH] ARM: Add support for Realtek SOC
>
> > > > @@ -148,6 +148,7 @@ endif
> > > >  textofs-$(CONFIG_ARCH_MSM8X60) := 0x00208000
> > > >  textofs-$(CONFIG_ARCH_MSM8960) := 0x00208000
> > > >  textofs-$(CONFIG_ARCH_MESON) := 0x00208000
> > > > +textofs-$(CONFIG_ARCH_REALTEK) := 0x00208000
> > > >  textofs-$(CONFIG_ARCH_AXXIA) := 0x00308000
> > >
> > > Can you explain why this is needed for your platform?
> > >
> > We need to reserve memory (0x00000000 ~ 0x001B0000) for rom and boot code.
>
> Ok.


I do not like this much.

This platform is ARCH_MULTI_V7.

ARM_PATCH_PHYS_VIRT allows you to place the kernel image
anywhere in memory as long as the base is aligned at 16MB.

The minimum 'textofs-y := 0x0008000' + extra 16MB offset
will create a space (0x00000000 ~ 0x01008000).

This is more than needed, but it is not a big deal
to waste some megabytes of memory.


-- 
Best Regards
Masahiro Yamada