Re: [PATCH 2/2] gpio: iproc-gpio: Handle interrupts for multiple instances

From: Linus Walleij
Date: Wed Sep 11 2019 - 05:43:12 EST


On Thu, Aug 29, 2019 at 5:52 AM Srinath Mannam
<srinath.mannam@xxxxxxxxxxxx> wrote:

> From: Rayagonda Kokatanur <rayagonda.kokatanur@xxxxxxxxxxxx>
>
> When multiple instance of iproc-gpio chips are present, a fix up
> message[1] is printed during the probe of second and later instances.
>
> This issue is because driver sharing same irq_chip data structure
> among multiple instances of driver.
>
> Fix this by allocating irq_chip data structure per instance of
> iproc-gpio.
>
> [1] fix up message addressed by this patch
> [ 7.862208] gpio gpiochip2: (689d0000.gpio): detected irqchip that
> is shared with multiple gpiochips: please fix the driver.
>
> Fixes: 616043d58a89 ("pinctrl: Rename gpio driver from cygnus to iproc")
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@xxxxxxxxxxxx>

Patch applied, I had to rewrite it a bit to fit the new code that
set up the irqchip when adding the gpio_chip, please check that
the result works.

Yours,
Linus Walleij