Re: [PATCH v5.1-rc] iwlwifi: make locking in iwl_mvm_tx_mpdu() BH-safe

From: Jiri Kosina
Date: Wed Sep 11 2019 - 08:04:21 EST


On Wed, 11 Sep 2019, Jiri Kosina wrote:

> From: Jiri Kosina <jkosina@xxxxxxx>
> Subject: [PATCH] iwlwifi: make locking in iwl_mvm_tx_mpdu() BH-safe

Hm, scratch that, that might actually spuriously enable BHs if called from
contexts that already did disabled BHs.

So what solution would you prefer here? Just stick another par of
bh_disable() / bh_enable() somewhere to the wake_txs() ->
iwl_mvm_mac_itxq_xmit() -> iwl_mvm_tx_skb() -> iwl_mvm_tx_mpdu() path?

Thanks,

--
Jiri Kosina
SUSE Labs