Re: [PATCH 08/10] blkcg: implement blk-iocost
From: Tejun Heo
Date: Wed Sep 11 2019 - 10:16:36 EST
Hello,
On Wed, Sep 11, 2019 at 10:18:53AM +0200, Paolo Valente wrote:
> > The two being enabled at the same time doesn't make sense, so we can
> > just switch over to bfq when bfq is selected as the iosched. I asked
> > what Paolo wanted to do in terms of interface a couple times now but
> > didn't get an answer and he posted a patch which makes the two
> > controllers conflict, so.... Paolo, so it looks like you want to
> > rename all bfq files to drop the bfq prefix, right?
>
> Yep, mainly because ... this is the solution you voted and you
> yourself proposed [1] :)
>
> [1] https://patchwork.kernel.org/patch/10988261/
So, that was then. Since then the interface change has been published
and userspace, at least some of them, already had to adjust. Now, I
don't have any opinion on the matter and flipping again will cause
inconveniences to some subset of users. It's your call.
> > I can implement
> > the switching if so.
>
> That would be perfect.
Whichever way it gets decided, this is easy enough. I'll prep a
patch.
Thanks.
--
tejun