Re: [PATCH v3 2/2] uacce: add uacce driver

[zhangfei]

On 2019/9/4 äå8:38, Greg Kroah-Hartman wrote:
> On Tue, Sep 03, 2019 at 12:14:47PM +0800, Zhangfei Gao wrote:
> > From: Kenneth Lee <liguozhu@xxxxxxxxxxxxx>
> >
> > Uacce (Unified/User-space-access-intended Accelerator Framework) targets to
> > provide Shared Virtual Addressing (SVA) between accelerators and processes.
> > So accelerator can access any data structure of the main cpu.
> > This differs from the data sharing between cpu and io device, which share
> > data content rather than address.
> > Since unified address, hardware and user space of process can share the
> > same virtual address in the communication.
> >
> > Uacce create a chrdev for every registration, the queue is allocated to
> > the process when the chrdev is opened. Then the process can access the
> > hardware resource by interact with the queue file. By mmap the queue
> > file space to user space, the process can directly put requests to the
> > hardware without syscall to the kernel space.
> >
> > Signed-off-by: Kenneth Lee <liguozhu@xxxxxxxxxxxxx>
> > Signed-off-by: Zaibo Xu <xuzaibo@xxxxxxxxxx>
> > Signed-off-by: Zhou Wang <wangzhou1@xxxxxxxxxxxxx>
> > Signed-off-by: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx>
> > ---
> >   Documentation/ABI/testing/sysfs-driver-uacce |   47 ++
> >   drivers/misc/Kconfig                         |    1 +
> >   drivers/misc/Makefile                        |    1 +
> >   drivers/misc/uacce/Kconfig                   |   13 +
> >   drivers/misc/uacce/Makefile                  |    2 +
> >   drivers/misc/uacce/uacce.c                   | 1096 ++++++++++++++++++++++++++
> >   include/linux/uacce.h                        |  172 ++++
> >   include/uapi/misc/uacce.h                    |   39 +
> >   8 files changed, 1371 insertions(+)
> >   create mode 100644 Documentation/ABI/testing/sysfs-driver-uacce
> >   create mode 100644 drivers/misc/uacce/Kconfig
> >   create mode 100644 drivers/misc/uacce/Makefile
> >   create mode 100644 drivers/misc/uacce/uacce.c
> >   create mode 100644 include/linux/uacce.h
> >   create mode 100644 include/uapi/misc/uacce.h
> >
> > diff --git a/Documentation/ABI/testing/sysfs-driver-uacce b/Documentation/ABI/testing/sysfs-driver-uacce
> > new file mode 100644
> > index 0000000..ee0a66e
> > --- /dev/null
> > +++ b/Documentation/ABI/testing/sysfs-driver-uacce
> > @@ -0,0 +1,47 @@
> > +What:           /sys/class/uacce/hisi_zip-<n>/id
> > +Date:           Sep 2019
> > +KernelVersion:  5.3
> 5.3 will be released in a week or so, without this file in it, so that's
> not ok here :(
Thanks, will use 5.4 instead.
Since 5.4-rc1 still need some time, can I send updated version based on 
5.3-rc8 for more review.
And I found smmu in 5.3-rc1 have issue, and rc8 is OK.

Thanks