Re: [PATCH 1/4] mm/hmm: make full use of walk_page_range()

[Ralph Campbell]

On 9/12/19 1:26 AM, Christoph Hellwig wrote:
> > +static int hmm_pfns_fill(unsigned long addr,
> > +			 unsigned long end,
> > +			 struct hmm_range *range,
> > +			 enum hmm_pfn_value_e value)
>
> Nit: can we use the space a little more efficient, e.g.:
>
> static int hmm_pfns_fill(unsigned long addr, unsigned long end,
> 		struct hmm_range *range, enum hmm_pfn_value_e value)
>
> > +static int hmm_vma_walk_test(unsigned long start,
> > +			     unsigned long end,
> > +			     struct mm_walk *walk)
>
> Same here.
>
> > +	if (!(vma->vm_flags & VM_READ)) {
> > +		(void) hmm_pfns_fill(start, end, range, HMM_PFN_NONE);
>
> There should be no need for the void cast here.

OK. I'll post a v2 with the these changes.
Thanks for the reviews.