Re: [PATCH v2 4/6] compiler-gcc.h: add asm_inline definition
From: Rasmus Villemoes
Date: Thu Sep 12 2019 - 18:12:47 EST
On 12/09/2019 23.54, Nick Desaulniers wrote:
> On Sat, Sep 7, 2019 at 6:11 AM Segher Boessenkool
> <segher@xxxxxxxxxxxxxxxxxxx> wrote:
>>
>> On Fri, Sep 06, 2019 at 06:04:54PM -0700, Nick Desaulniers wrote:
>>
>>> How would you even write a version check for that?
>>
>> I wouldn't. Please stop using that straw man. I'm not saying version
>> checks are good, or useful for most things. I am saying they are not.
>
> Then please help Rasmus with a suggestion on how best to detect and
> safely make use of the feature you implemented. As is, the patch in
> question is using version checks.
I was just about to send out an updated version. I'm just going to do
the check in Kconfig - I didn't realize how easy it had become to do
that kind of thing until Masahiro pointed me at his RFC patch from December.
Rasmus