Re: [PATCH bpf-next 01/11] samples: bpf: makefile: fix HDR_PROBE "echo"

[Ivan Khoronzhuk]

On Wed, Sep 11, 2019 at 02:02:11PM +0300, Sergei Shtylyov wrote:
> On 10.09.2019 17:54, Ivan Khoronzhuk wrote:
>
> > > Hello!
> > >
> > > On 10.09.2019 13:38, Ivan Khoronzhuk wrote:
> > >
> > > > echo should be replaced on echo -e to handle \n correctly, but instead,
> > >
> > >  s/on/with/?
> > s/echo/printf/ instead of s/echo/echo -e/
>
>   I only pointed that 'on' is incorrect there. You replace something 
> /with/ something other...
>
> > printf looks better.
> >
> > > > replace it on printf as some systems can't handle echo -e.
> > >
> > >   Likewise?
>
>   Same grammatical mistake.
Oh, will correct it next v.


--
Regards,
Ivan Khoronzhuk