Re: [PATCH 0/4] *** AMD PTDMA driver ***

[Vinod Koul]

On 24-09-19, 07:31, Mehta, Sanju wrote:
> From: Sanjay R Mehta <sanju.mehta@xxxxxxx>
> 
> *** This patch series adds support for AMD PTDMA engine ***

What lots of stars!

Can you describe the controller a bit more to help people set the
context for the review!

And also helps to make the email subject as "Add AMD PTDMA driver ...."
or similar!

> 
> Sanjay R Mehta (4):
>   dma: Add PTDMA Engine driver support
>   dma: Support for multiple PTDMA
>   dmaengine: Register as a DMA resource
>   dmaengine: Add debugfs entries for PTDMA information

Can you be consistent with naming, and yes do use dmaengine!

> 
>  MAINTAINERS                         |   6 +
>  drivers/dma/Kconfig                 |   2 +
>  drivers/dma/Makefile                |   1 +
>  drivers/dma/ptdma/Kconfig           |   8 +
>  drivers/dma/ptdma/Makefile          |  12 +
>  drivers/dma/ptdma/ptdma-debugfs.c   | 249 +++++++++++++
>  drivers/dma/ptdma/ptdma-dev.c       | 445 +++++++++++++++++++++++
>  drivers/dma/ptdma/ptdma-dmaengine.c | 700 ++++++++++++++++++++++++++++++++++++
>  drivers/dma/ptdma/ptdma-ops.c       | 464 ++++++++++++++++++++++++
>  drivers/dma/ptdma/ptdma-pci.c       | 244 +++++++++++++
>  drivers/dma/ptdma/ptdma.h           | 563 +++++++++++++++++++++++++++++
>  11 files changed, 2694 insertions(+)
>  create mode 100644 drivers/dma/ptdma/Kconfig
>  create mode 100644 drivers/dma/ptdma/Makefile
>  create mode 100644 drivers/dma/ptdma/ptdma-debugfs.c
>  create mode 100644 drivers/dma/ptdma/ptdma-dev.c
>  create mode 100644 drivers/dma/ptdma/ptdma-dmaengine.c
>  create mode 100644 drivers/dma/ptdma/ptdma-ops.c
>  create mode 100644 drivers/dma/ptdma/ptdma-pci.c
>  create mode 100644 drivers/dma/ptdma/ptdma.h
> 
> -- 
> 2.7.4

-- 
~Vinod