Re: [PATCH] x86, realmode: explicitly set ENTRY in linker script

From: Sedat Dilek
Date: Tue Sep 24 2019 - 13:31:15 EST


On Tue, Sep 24, 2019 at 12:24 AM 'Nick Desaulniers' via Clang Built
Linux <clang-built-linux@xxxxxxxxxxxxxxxx> wrote:
>
> Linking with ld.lld via $ make LD=ld.lld produces the warning:
> ld.lld: warning: cannot find entry symbol _start; defaulting to 0x1000
>
> Linking with ld.bfd shows the default entry is 0x1000:
> $ readelf -h arch/x86/realmode/rm/realmode.elf | grep Entry
> Entry point address: 0x1000
>
> While ld.lld is being pedantic, just set the entry point explicitly,
> instead of depending on the implicit default.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/216

Reported-by: Sedat Dilek <sedat.dilek@xxxxxxxxx> (seen on my first
steps when linking with LLD on x86-64)

> Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
> ---
> arch/x86/realmode/rm/realmode.lds.S | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/realmode/rm/realmode.lds.S b/arch/x86/realmode/rm/realmode.lds.S
> index 3bb980800c58..2034f5f79bff 100644
> --- a/arch/x86/realmode/rm/realmode.lds.S
> +++ b/arch/x86/realmode/rm/realmode.lds.S
> @@ -11,6 +11,7 @@
>
> OUTPUT_FORMAT("elf32-i386")
> OUTPUT_ARCH(i386)
> +ENTRY(0x1000)
>
> SECTIONS
> {
> --
> 2.23.0.351.gc4317032e6-goog
>
> --
> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@xxxxxxxxxxxxxxxxx
> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20190923222403.22956-1-ndesaulniers%40google.com.