Re: [PATCH] kcm: use BPF_PROG_RUN

[Eric Dumazet]

On 9/24/19 11:59 AM, Daniel Borkmann wrote:
> On Mon, Sep 23, 2019 at 02:31:04PM -0700, Eric Dumazet wrote:
>> On 9/6/19 10:06 AM, Alexei Starovoitov wrote:
>>> On Fri, Sep 6, 2019 at 3:03 AM Yonghong Song <yhs@xxxxxx> wrote:
>>>> On 9/5/19 2:15 PM, Sami Tolvanen wrote:
>>>>> Instead of invoking struct bpf_prog::bpf_func directly, use the
>>>>> BPF_PROG_RUN macro.
>>>>>
>>>>> Signed-off-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx>
>>>>
>>>> Acked-by: Yonghong Song <yhs@xxxxxx>
>>>
>>> Applied. Thanks
>>
>> Then we probably need this as well, what do you think ?
> 
> Yep, it's broken. 6cab5e90ab2b ("bpf: run bpf programs with preemption
> disabled") probably forgot about it since it wasn't using BPF_PROG_RUN()
> in the first place. If you get a chance, please send a proper patch,
> thanks!

Sure, I will send this today.