Re: [PATCH] dmaengine: jz4780: Use devm_platform_ioremap_resource() in jz4780_dma_probe()

[Paul Cercueil]

Hi Markus,


Le dim. 22 sept. 2019 à 11:25, Markus Elfring <Markus.Elfring@xxxxxx> 
a écrit :
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Sun, 22 Sep 2019 11:18:27 +0200
>
> Simplify this function implementation a bit by using
> a known wrapper function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>

Looks good to me.

Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>


> ---
>  drivers/dma/dma-jz4780.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c
> index cafb1cc065bb..f42b3ef8e036 100644
> --- a/drivers/dma/dma-jz4780.c
> +++ b/drivers/dma/dma-jz4780.c
> @@ -858,13 +858,7 @@ static int jz4780_dma_probe(struct 
> platform_device *pdev)
>  	jzdma->soc_data = soc_data;
>  	platform_set_drvdata(pdev, jzdma);
>
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (!res) {
> -		dev_err(dev, "failed to get I/O memory\n");
> -		return -EINVAL;
> -	}
> -
> -	jzdma->chn_base = devm_ioremap_resource(dev, res);
> +	jzdma->chn_base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(jzdma->chn_base))
>  		return PTR_ERR(jzdma->chn_base);
>
> --
> 2.23.0