Re: [PATCH] staging: olpc_dcon: fix wrong dependencies in Kconfig file

From: Dan Carpenter
Date: Wed Sep 25 2019 - 03:34:16 EST


On Wed, Sep 25, 2019 at 03:25:33PM +0800, Jerry Lin wrote:
> To allow simultaneous support for XO-1 and XO-1.5.
> This module require GPIO_CS5535 (for 1.0) and ACPI (for 1.5) now.
>
> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> Signed-off-by: Jerry Lin <wahahab11@xxxxxxxxx>
> ---
> drivers/staging/olpc_dcon/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/olpc_dcon/Kconfig b/drivers/staging/olpc_dcon/Kconfig
> index 4ae271f..c2429e4 100644
> --- a/drivers/staging/olpc_dcon/Kconfig
> +++ b/drivers/staging/olpc_dcon/Kconfig
> @@ -3,7 +3,7 @@ config FB_OLPC_DCON
> tristate "One Laptop Per Child Display CONtroller support"
> depends on OLPC && FB
> depends on I2C
> - depends on (GPIO_CS5535 || ACPI)
> + depends on (GPIO_CS5535 && ACPI)

Please, remove the parentheses as well.

regards,
dan carpenter