Re: [PATCH 1/3] drm: Add some new format DRM_FORMAT_NVXX_10

[Maarten Lankhorst]

Op 25-09-2019 om 10:32 schreef sandy.huang:
>
> å 2019/9/25 äå4:17, Maarten Lankhorst åé:
>> Op 25-09-2019 om 10:06 schreef Sandy Huang:
>>> These new format is supported by some rockchip socs:
>>>
>>> DRM_FORMAT_NV12_10/DRM_FORMAT_NV21_10
>>> DRM_FORMAT_NV16_10/DRM_FORMAT_NV61_10
>>> DRM_FORMAT_NV24_10/DRM_FORMAT_NV42_10
>>>
>>> Signed-off-by: Sandy Huang <hjc@xxxxxxxxxxxxxx>
>>> ---
>>>  drivers/gpu/drm/drm_fourcc.c | 18 ++++++++++++++++++
>>> Â include/uapi/drm/drm_fourcc.h | 14 ++++++++++++++
>>> Â 2 files changed, 32 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c
>>> index c630064..f25fa81 100644
>>> --- a/drivers/gpu/drm/drm_fourcc.c
>>> +++ b/drivers/gpu/drm/drm_fourcc.c
>>> @@ -274,6 +274,24 @@ const struct drm_format_info *__drm_format_info(u32 format)
>>> ÂÂÂÂÂÂÂÂÂ { .format = DRM_FORMAT_YUV420_10BIT,ÂÂÂ .depth = 0,
>>> ÂÂÂÂÂÂÂÂÂÂÂ .num_planes = 1, .cpp = { 0, 0, 0 }, .hsub = 2, .vsub = 2,
>>> ÂÂÂÂÂÂÂÂÂÂÂ .is_yuv = true },
>>> +ÂÂÂÂÂÂÂ { .format = DRM_FORMAT_NV12_10,ÂÂÂÂÂÂÂ .depth = 0,
>>> +ÂÂÂÂÂÂÂÂÂ .num_planes = 2, .cpp = { 0, 0, 0 }, .hsub = 2, .vsub = 2,
>>> +ÂÂÂÂÂÂÂÂÂ .is_yuv = true },
>>> +ÂÂÂÂÂÂÂ { .format = DRM_FORMAT_NV21_10,ÂÂÂÂÂÂÂ .depth = 0,
>>> +ÂÂÂÂÂÂÂÂÂ .num_planes = 2, .cpp = { 0, 0, 0 }, .hsub = 2, .vsub = 2,
>>> +ÂÂÂÂÂÂÂÂÂ .is_yuv = true },
>>> +ÂÂÂÂÂÂÂ { .format = DRM_FORMAT_NV16_10,ÂÂÂÂÂÂÂ .depth = 0,
>>> +ÂÂÂÂÂÂÂÂÂ .num_planes = 2, .cpp = { 0, 0, 0 }, .hsub = 2, .vsub = 1,
>>> +ÂÂÂÂÂÂÂÂÂ .is_yuv = true },
>>> +ÂÂÂÂÂÂÂ { .format = DRM_FORMAT_NV61_10,ÂÂÂÂÂÂÂ .depth = 0,
>>> +ÂÂÂÂÂÂÂÂÂ .num_planes = 2, .cpp = { 0, 0, 0 }, .hsub = 2, .vsub = 1,
>>> +ÂÂÂÂÂÂÂÂÂ .is_yuv = true },
>>> +ÂÂÂÂÂÂÂ { .format = DRM_FORMAT_NV24_10,ÂÂÂÂÂÂÂ .depth = 0,
>>> +ÂÂÂÂÂÂÂÂÂ .num_planes = 2, .cpp = { 0, 0, 0 }, .hsub = 1, .vsub = 1,
>>> +ÂÂÂÂÂÂÂÂÂ .is_yuv = true },
>>> +ÂÂÂÂÂÂÂ { .format = DRM_FORMAT_NV42_10,ÂÂÂÂÂÂÂ .depth = 0,
>>> +ÂÂÂÂÂÂÂÂÂ .num_planes = 2, .cpp = { 0, 0, 0 }, .hsub = 1, .vsub = 1,
>>> +ÂÂÂÂÂÂÂÂÂ .is_yuv = true },
>>> ÂÂÂÂÂ };
>>> Â ÂÂÂÂÂ unsigned int i;
>>> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
>>> index 3feeaa3..0479f47 100644
>>> --- a/include/uapi/drm/drm_fourcc.h
>>> +++ b/include/uapi/drm/drm_fourcc.h
>>> @@ -238,6 +238,20 @@ extern "C" {
>>> Â #define DRM_FORMAT_NV42ÂÂÂÂÂÂÂ fourcc_code('N', 'V', '4', '2') /* non-subsampled Cb:Cr plane */
>>> Â Â /*
>>> + * 2 plane YCbCr 10bit
>>> + * index 0 = Y plane, [9:0] Y
>>> + * index 1 = Cr:Cb plane, [19:0]
>>> + * or
>>> + * index 1 = Cb:Cr plane, [19:0]
>>> + */
>>> +#define DRM_FORMAT_NV12_10ÂÂÂ fourcc_code('N', 'A', '1', '2') /* 2x2 subsampled Cr:Cb plane */
>>> +#define DRM_FORMAT_NV21_10ÂÂÂ fourcc_code('N', 'A', '2', '1') /* 2x2 subsampled Cb:Cr plane */
>>> +#define DRM_FORMAT_NV16_10ÂÂÂ fourcc_code('N', 'A', '1', '6') /* 2x1 subsampled Cr:Cb plane */
>>> +#define DRM_FORMAT_NV61_10ÂÂÂ fourcc_code('N', 'A', '6', '1') /* 2x1 subsampled Cb:Cr plane */
>>> +#define DRM_FORMAT_NV24_10ÂÂÂ fourcc_code('N', 'A', '2', '4') /* non-subsampled Cr:Cb plane */
>>> +#define DRM_FORMAT_NV42_10ÂÂÂ fourcc_code('N', 'A', '4', '2') /* non-subsampled Cb:Cr plane */
>>> +
>>> +/*
>>> ÂÂ * 2 plane YCbCr MSB aligned
>>> ÂÂ * index 0 = Y plane, [15:0] Y:x [10:6] little endian
>>> ÂÂ * index 1 = Cr:Cb plane, [31:0] Cr:x:Cb:x [10:6:10:6] little endian
>> What are the other bits, they are not mentioned?
>
> It's compact layout
>
> Yplane:
>
> ÂÂÂ Y0[9:0]Y1[9:0]Y2[9:0]Y3[9:0]...
>
> UVplane:
>
> ÂÂÂ U0[9:0]V0[9:0]U1[9:0]V1[9:0]... 

This should be put in the comment then, for clarity. :) Probably needs 4 pixels to describe how it fits in 5 (or 10 for cbcr) bytes.

Cheers,

Maarten