Re: [PATCH net v2 0/3] net/smc: move some definitions to UAPI

From: Ursula Braun
Date: Wed Sep 25 2019 - 08:10:14 EST




On 9/24/19 4:52 PM, David Miller wrote:
> From: Eugene Syromiatnikov <esyr@xxxxxxxxxx>
> Date: Fri, 20 Sep 2019 17:41:47 +0200
>
>> As of now, it's a bit difficult to use SMC protocol, as significant part
>> of definitions related to it are defined in private headers and are not
>> part of UAPI. The following commits move some definitions to UAPI,
>> making them readily available to the user space.
>>
>> Changes since v1[1]:
>> * Patch "provide fallback diagnostic codes in UAPI" is updated
>> in accordance with the updated set of diagnostic codes.
>>
>> [1] https://lkml.org/lkml/2018/10/7/177
>
> Isn't it way too late for this?
>
> These definitions will now be duplicates for userland code that
> defines the values on their own.
>

Dave,
we have to admit that it is already late for these patches. Nevertheless
we think it is better to come up with them now than never. We doubt there
exists already much userland code for it - except our own IBM-provided
package smc-tools. Thus we appreciate acceptance of these patches.

Kind regards, Ursula