RE: [PATCH] net: stmmac: Fix ASSERT_RTNL() warning on suspend/resume

[Loys Ollivier]

On Tue 17 Sep 2019 at 10:12, Jose Abreu <Jose.Abreu@xxxxxxxxxxxx> wrote:

> From: Loys Ollivier <lollivier@xxxxxxxxxxxx>
> Date: Sep/17/2019, 11:02:36 (UTC+00:00)
>
>> rtnl_lock needs to be taken before calling phylink_start/stop to lock the
>> network stack.
>> Fix ASSERT_RTNL() warnings by protecting such calls with lock/unlock.
>> 
>> Fixes: 74371272f97f ("net: stmmac: Convert to phylink and remove phylib logic")
>> Signed-off-by: Loys Ollivier <lollivier@xxxxxxxxxxxx>
>
> I already sent a fix for this. Please see in -net:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/driv
> ers/net/ethernet/stmicro/stmmac?id=19e13cb27b998ff49f07e399b5871bfe5ba7e3
> f0

Ah good catch :)

>
> ---
> Thanks,
> Jose Miguel Abreu