Re: [PATCH] toplevel: Move ipc/ to kernel/ipc/: don't check the ipc dir
From: Joe Perches
Date: Wed Sep 25 2019 - 12:32:44 EST
On Wed, 2019-09-25 at 20:37 +0800, Yunfeng Ye wrote:
> After the commit 76128326f97c ("toplevel: Move ipc/ to kernel/ipc/: move
> the files"), we met some error messages:
>
> ./scripts/checkpatch.pl:
> "Must be run from the top-level dir. of a kernel tree"
>
> ./scripts/get_maintainer.pl:
> "The current directory does not appear to be a linux kernel source tree.
>
> Don't check the ipc dir in checkpatch.pl and get_maintainer.pl.
Thanks.
Maybe the commit subject could use "scripts:"
or something similar and not "toplevel:".
Trivially, it one day it'd be good to use the
same routine and output message too.
> Signed-off-by: Yunfeng Ye <yeyunfeng@xxxxxxxxxx>
> ---
> scripts/checkpatch.pl | 2 +-
> scripts/get_maintainer.pl | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 93a7edf..6117d0e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1097,7 +1097,7 @@ sub top_of_kernel_tree {
> my @tree_check = (
> "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
> "README", "Documentation", "arch", "include", "drivers",
> - "fs", "init", "ipc", "kernel", "lib", "scripts",
> + "fs", "init", "kernel", "lib", "scripts",
> );
>
> foreach my $check (@tree_check) {
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 5ef5921..2e42aeb 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -1109,7 +1109,6 @@ sub top_of_kernel_tree {
> && (-d "${lk_path}drivers")
> && (-d "${lk_path}fs")
> && (-d "${lk_path}init")
> - && (-d "${lk_path}ipc")
> && (-d "${lk_path}kernel")
> && (-d "${lk_path}lib")
> && (-d "${lk_path}scripts")) {