Re: [PATCH 2/2] tracing, vmscan: add comments for perf script page-reclaim

From: Tony Jones
Date: Wed Sep 25 2019 - 15:24:41 EST


On 9/18/19 7:38 AM, Yafang Shao wrote:
> Currently there's no easy way to make perf scripts in sync with
> tracepoints. One possible way is to run perf's tests regularly, another way
> is once we changes the definitions of tracepoints we must keep in mind that
> the perf scripts which are using these tracepoints must be changed as well.
> So I add this comment for the new introduced page-reclaim script as a
> reminder.
>
> Signed-off-by: Yafang Shao <laoar.shao@xxxxxxxxx>

This seems like the tail wagging the dog to me. If we added this to every tp defn that is used by a perf perl/python script the tp headers would be littered with such comments.