Re: [PATCH 07/32] x86: Use pr_warn instead of pr_warning

[Kefeng Wang]

On 2019/9/20 23:28, Joe Perches wrote:
> On Fri, 2019-09-20 at 19:57 +0800, Kefeng Wang wrote:
>> On 2019/9/20 17:28, Robert Richter wrote:
>>> On 20.09.19 14:25:19, Kefeng Wang wrote:
>>>> As said in commit f2c2cbcc35d4 ("powerpc: Use pr_warn instead of
>>>> pr_warning"), removing pr_warning so all logging messages use a
>>>> consistent <prefix>_warn style. Let's do it.
> []
>>>> diff --git a/arch/x86/kernel/amd_gart_64.c b/arch/x86/kernel/amd_gart_64.c
> []
>>>> @@ -665,7 +664,7 @@ static __init int init_amd_gatt(struct agp_kern_info *info)
>>>>  
>>>>   nommu:
>>>>  	/* Should not happen anymore */
>>>> -	pr_warning("PCI-DMA: More than 4GB of RAM and no IOMMU\n"
>>>> +	pr_warn("PCI-DMA: More than 4GB of RAM and no IOMMU\n"
>>>>  	       "falling back to iommu=soft.\n");
>>> This indentation should be fixed too, while at it.
>> Will update later, thanks.
> trivia:
>
> likely better as a single line output:
>
> 	pr_warn("PCI-DMA: More than 4GB of RAM and no IOMMU - falling back to iommu=soft\n");

ok, will resend all patches after rc1 with this change and other comment fixes, thanks.

>
>
>
> .
>