Re: [PATCH 57/66] perf evsel: Introduce evsel_fprintf.h

[Jiri Olsa]

On Wed, Sep 25, 2019 at 09:32:35PM -0300, Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> 
> We already had evsel_fprintf.c, add its counterpart, so that we can
> reduce evsel.h a bit more.
> 
> We needed a new perf_event_attr_fprintf.c file so as to have a separate
> object to link with the python binding in tools/perf/util/python-ext-sources
> and not drag symbol_conf, etc into the python binding.
> 
> Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> Link: https://lkml.kernel.org/n/tip-06bdmt1062d9unzgqmxwlv88@xxxxxxxxxxxxxx
> Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> ---
>  tools/perf/builtin-evlist.c               |   1 +
>  tools/perf/builtin-sched.c                |   1 +
>  tools/perf/builtin-script.c               |   1 +
>  tools/perf/builtin-trace.c                |   2 +
>  tools/perf/util/Build                     |   1 +
>  tools/perf/util/evsel.c                   | 153 +---------------------
>  tools/perf/util/evsel.h                   |  51 +-------
>  tools/perf/util/evsel_fprintf.c           |   1 +
>  tools/perf/util/evsel_fprintf.h           |  50 +++++++
>  tools/perf/util/header.c                  |   1 +
>  tools/perf/util/perf_event_attr_fprintf.c | 148 +++++++++++++++++++++
>  tools/perf/util/python-ext-sources        |   1 +
>  12 files changed, 218 insertions(+), 193 deletions(-)
>  create mode 100644 tools/perf/util/evsel_fprintf.h
>  create mode 100644 tools/perf/util/perf_event_attr_fprintf.c

hum, I see this file in this patch, but not when I checkout yours perf/core

jirka