Re: [PATCH] KVM: nVMX: cleanup and fix host 64-bit mode checks

From: Liran Alon
Date: Thu Sep 26 2019 - 07:31:33 EST




> On 25 Sep 2019, at 19:34, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
>
> KVM was incorrectly checking vmcs12->host_ia32_efer even if the "load
> IA32_EFER" exit control was reset. Also, some checks were not using
> the new CC macro for tracing.
>
> Cleanup everything so that the vCPU's 64-bit mode is determined
> directly from EFER_LMA and the VMCS checks are based on that, which
> matches section 26.2.4 of the SDM.
>
> Cc: Sean Christopherson <sean.j.christopherson@xxxxxxxxx>
> Cc: Jim Mattson <jmattson@xxxxxxxxxx>
> Cc: Krish Sadhukhan <krish.sadhukhan@xxxxxxxxxx>
> Fixes: 5845038c111db27902bc220a4f70070fe945871c
> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> â

Reviewed-by: Liran Alon <liran.alon@xxxxxxxxxx>