Re: [PATCH] async: Let kfree() out of the critical area of the lock

From: Bart Van Assche
Date: Thu Sep 26 2019 - 11:18:43 EST


On 9/26/19 4:06 AM, David Sterba wrote:
On Thu, Sep 26, 2019 at 03:58:36PM +0800, Yunfeng Ye wrote:
The async_lock is big global lock, I think it's good to put kfree() outside
to keep the critical area as short as possible.

Agreed, kfree is not always cheap. We had patches in btrfs moving kfree
out of critical section(s) after causing softlockups due to increased lock
contention.

The above would be a great addition for the commit description. Anyway:

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>