RE: [PATCH] ACPICA: make acpi_load_table() return table index

[Schmauss, Erik]

> -----Original Message-----
> From: linux-acpi-owner@xxxxxxxxxxxxxxx <linux-acpi-owner@xxxxxxxxxxxxxxx>
> On Behalf Of Shevchenko, Andriy
> Sent: Thursday, September 26, 2019 9:35 AM
> To: Schmauss, Erik <erik.schmauss@xxxxxxxxx>
> Cc: Nikolaus Voss <nikolaus.voss@xxxxxxxxxxxxxxxxxxxxx>; Rafael J. Wysocki
> <rjw@xxxxxxxxxxxxx>; Moore, Robert <robert.moore@xxxxxxxxx>; Len Brown
> <lenb@xxxxxxxxxx>; Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>; Pavel
> Machek <pavel@xxxxxx>; Dan Murphy <dmurphy@xxxxxx>; linux-
> acpi@xxxxxxxxxxxxxxx; devel@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> nv@xxxxxxx
> Subject: Re: [PATCH] ACPICA: make acpi_load_table() return table index
> 
> On Thu, Sep 26, 2019 at 07:09:05PM +0300, Schmauss, Erik wrote:
> > > -----Original Message-----
> > > From: Nikolaus Voss <nikolaus.voss@xxxxxxxxxxxxxxxxxxxxx>
> > > Sent: Thursday, September 12, 2019 1:08 AM
> > > To: Shevchenko, Andriy <andriy.shevchenko@xxxxxxxxx>; Schmauss, Erik
> > > <erik.schmauss@xxxxxxxxx>; Rafael J. Wysocki <rjw@xxxxxxxxxxxxx>;
> > > Moore, Robert <robert.moore@xxxxxxxxx>
> > > Cc: Len Brown <lenb@xxxxxxxxxx>; Jacek Anaszewski
> > > <jacek.anaszewski@xxxxxxxxx>; Pavel Machek <pavel@xxxxxx>; Dan
> > > Murphy <dmurphy@xxxxxx>; linux-acpi@xxxxxxxxxxxxxxx;
> > > devel@xxxxxxxxxx; linux- kernel@xxxxxxxxxxxxxxx; nv@xxxxxxx;
> > > Nikolaus Voss <nikolaus.voss@xxxxxxxxxxxxxxxxxxxxx>
> > > Subject: [PATCH] ACPICA: make acpi_load_table() return table index
> > >
> > Hi Nikolaus,
> >
> > > For unloading an ACPI table, it is necessary to provide the index of the table.
> > > The method intended for dynamically loading or hotplug addition of
> > > tables, acpi_load_table(), should provide this information via an
> > > optional pointer to the loaded table index.
> >
> > We'll take this patch for ACPICA upstream
> 
> Erik,
> 
Hi Andy,

> how about to have also counterpart to acpi_load_table() which will do what it's
> done now in acpi_configfs.c via acpi_tb_*() API?

I should have given more details. We decided to add this extra parameter in AcpiLoadTable and
we're going to create an AcpiUnloadTable function that will take table index to unload the table (basically the acpi_tb_unload..).
Once we do this, you can use table indices with AcpiUnloadTable and AcpiLoadTable.

Erik
> 
> Because it's kinda strange to call acpi_load_table*() and acpi_tb_*() in the
> same module.
> 
> --
> With Best Regards,
> Andy Shevchenko
>