RE: [PATCH 4/4] PCI: hv: Change pci_protocol_version to per-hbus

[Dexuan Cui]

> From: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
> Sent: Thursday, September 26, 2019 9:29 AM
> 
> On Wed, Sep 11, 2019 at 11:38:23PM +0000, Dexuan Cui wrote:
> > A VM can have multiple hbus. It looks incorrect for the second hbus's
> > hv_pci_protocol_negotiation() to set the global variable
> > 'pci_protocol_version' (which was set by the first hbus), even if the
> > same value is written.
> >
> > Signed-off-by: Dexuan Cui <decui@xxxxxxxxxxxxx>
> 
> This is a fix that seems unrelated to the rest of the series.

Correct.
 
> AFAICS the version also affects code paths in the driver, which
> means that in case you have busses with different versions the
> current code is wrong in this respect.

Correct.

> You have to capture this concept in the commit log, it reads as
> an optional change but it looks like a potential bug.
> 
> Lorenzo

Agreed. Let me improve the commit log in v2.

Thanks,
-- Dexuan