Re: [PATCH v3] PCI: aardvark: Don't rely on jiffies while holding spinlock

[Thomas Petazzoni]

On Fri, 27 Sep 2019 10:55:02 +0200
Remi Pommarel <repk@xxxxxxxxxxxx> wrote:

> advk_pcie_wait_pio() can be called while holding a spinlock (from
> pci_bus_read_config_dword()), then depends on jiffies in order to
> timeout while polling on PIO state registers. In the case the PIO
> transaction failed, the timeout will never happen and will also cause
> the cpu to stall.
> 
> This decrements a variable and wait instead of using jiffies.
> 
> Signed-off-by: Remi Pommarel <repk@xxxxxxxxxxxx>

Acked-by: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx>

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com