Re: [PATCH] vsock/virtio: add support for MSG_PEEK

From: Eric Dumazet
Date: Fri Sep 27 2019 - 09:37:05 EST




On 9/27/19 1:55 AM, Stefano Garzarella wrote:

> Good catch!
>
> Maybe we can solve in this way:
>
> list_for_each_entry(pkt, &vvs->rx_queue, list) {
> size_t off = pkt->off;
>
> if (total == len)
> break;
>
> while (total < len && off < pkt->len) {
> /* using 'off' instead of 'pkt->off' */
> ...
>
> total += bytes;
> off += bytes;
> }
> }
>
> What do you think?
>

Maybe, but I need to see a complete patch, evil is in the details :)