Re: [PATCH] selftests/ftrace: Fix same probe error test

[Masami Hiramatsu]

On Fri, 27 Sep 2019 11:25:14 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> 
> From: "Steven Rostedt (VMware)" <rostedt@xxxxxxxxxxx>
> 
> The "same probe" selftest that tests that adding the same probe fails
> doesn't add the same probe and passes, which fails the test.
> 
> Fixes: b78b94b82122 ("selftests/ftrace: Update kprobe event error testcase")
> Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

Oops, thanks!

Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>

> ---
>  .../selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc      | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc
> index 8a4025e912cb..ef1e9bafb098 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc
> @@ -95,7 +95,7 @@ echo 'p:kprobes/testevent _do_fork abcd=\1' > kprobe_events
>  check_error 'p:kprobes/testevent _do_fork ^bcd=\1'	# DIFF_ARG_TYPE
>  check_error 'p:kprobes/testevent _do_fork ^abcd=\1:u8'	# DIFF_ARG_TYPE
>  check_error 'p:kprobes/testevent _do_fork ^abcd=\"foo"'	# DIFF_ARG_TYPE
> -check_error '^p:kprobes/testevent _do_fork'	# SAME_PROBE
> +check_error '^p:kprobes/testevent _do_fork abcd=\1'	# SAME_PROBE
>  fi
>  
>  exit 0
> -- 
> 2.20.1
> 


-- 
Masami Hiramatsu <mhiramat@xxxxxxxxxx>