Re: [PATCH RESEND] gen-insn-attr-x86.awk: Fix regexp warnings

From: Borislav Petkov
Date: Mon Sep 30 2019 - 01:35:36 EST


On Tue, Sep 24, 2019 at 07:46:59AM +0300, Alexander Kapshuk wrote:
> gawk 5.0.1 generates the regexp warnings shown below:
> GEN /home/sasha/torvalds/tools/objtool/arch/x86/lib/inat-tables.c
> awk: ../arch/x86/tools/gen-insn-attr-x86.awk:260: warning: regexp escape sequence `\:' is not a known regexp operator
> awk: ../arch/x86/tools/gen-insn-attr-x86.awk:350: (FILENAME=../arch/x86/lib/x86-opcode-map.txt FNR=41) warning: regexp escape sequence `\&' is not a known regexp operator
>
> Ealier versions of gawk are not known to generate these warnings.
>
> The gawk manual referenced below does not list characters ':' and '&'
> as needing escaping, so 'unescape' them.
> https://www.gnu.org/software/gawk/manual/html_node/Escape-Sequences.html
>
> Running diff on the output generated by the script before and after
> applying the patch reported no differences.
>
> Signed-off-by: Alexander Kapshuk <alexander.kapshuk@xxxxxxxxx>
> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> Reviewed-by: Borislav Petkov <bp@xxxxxxxxx>

This is not how Reviewed-by works. Read here:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes

for future reference. I fixed it up now.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette