Re: [PATCH v2 net 9/9] net: stmmac: xgmac: Fix RSS writing wrong keys

[Arnd Bergmann]

On Mon, Sep 30, 2019 at 10:19 AM Jose Abreu <Jose.Abreu@xxxxxxxxxxxx> wrote:
>
> Commit b6b6cc9acd7b, changed the call to dwxgmac2_rss_write_reg()
> passing it the variable cfg->key[i].
>
> As key is an u8 but we write 32 bits at a time we need to cast it into
> an u32 so that the correct key values are written. Notice that the for
> loop already takes this into account so we don't try to write past the
> keys size.

Right, sorry about my mistake.

> Fixes: b6b6cc9acd7b ("net: stmmac: selftest: avoid large stack usage")
> Signed-off-by: Jose Abreu <Jose.Abreu@xxxxxxxxxxxx>

Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>