Re: [PATCH] dimlib: make DIMLIB a hidden symbol

[Geert Uytterhoeven]

Hi Uwe, Tal,

On Sat, Sep 21, 2019 at 7:50 PM Uwe Kleine-KÃnig <uwe@xxxxxxxxxxxxxxxxx> wrote:
> According to Tal Gilboa the only benefit from DIM comes from a driver
> that uses it. So it doesn't make sense to make this symbol user visible,
> instead all drivers that use it should select it (as is already the case
> AFAICT).
>
> Signed-off-by: Uwe Kleine-KÃnig <uwe@xxxxxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -555,8 +555,7 @@ config SIGNATURE
>           Implementation is done using GnuPG MPI library
>
>  config DIMLIB
> -       bool "DIM library"
> -       default y
> +       bool
>         help
>           Dynamic Interrupt Moderation library.
>           Implements an algorithm for dynamically change CQ moderation values

Thanks for fixing the first issue!

The second issue is still present: NET_VENDOR_BROADCOM (which defaults
to y, as all other NET_VENDOR_* symbols) should only be a gatekeeper for
the various Broadcom network driver config options, and should not select
DIMLIB.

Cfr. my earlier complaint in
https://lore.kernel.org/linux-rdma/alpine.DEB.2.21.1907021810220.13058@xxxxxxxxxxxxxx/

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds