Re: [PATCH 2/7] hwrng: omap3-rom - Fix missing clock by probing with device tree

[Rob Herring]

On Sat, 14 Sep 2019 14:02:55 -0700, Tony Lindgren wrote:
> Commit 0ed266d7ae5e ("clk: ti: omap3: cleanup unnecessary clock aliases")
> removed old omap3 clock framework aliases but caused omap3-rom-rng to
> stop working with clock not found error.
> 
> Based on discussions on the mailing list it was requested by Tero Kristo
> that it would be best to fix this issue by probing omap3-rom-rng using
> device tree to provide a proper clk property. The other option would be
> to add back the missing clock alias, but that does not help moving things
> forward with removing old legacy platform_data.
> 
> Let's also add a proper device tree binding and keep it together with
> the fix.
> 
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: Aaro Koskinen <aaro.koskinen@xxxxxx>
> Cc: Adam Ford <aford173@xxxxxxxxx>
> Cc: Pali Rohár <pali.rohar@xxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Sebastian Reichel <sre@xxxxxxxxxx>
> Cc: Tero Kristo <t-kristo@xxxxxx>
> Fixes: 0ed266d7ae5e ("clk: ti: omap3: cleanup unnecessary clock aliases")
> Reported-by: Aaro Koskinen <aaro.koskinen@xxxxxx>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> ---
>  .../devicetree/bindings/rng/omap3_rom_rng.txt | 27 +++++++++++++++++++
>  arch/arm/boot/dts/omap3-n900.dts              |  6 +++++
>  arch/arm/mach-omap2/pdata-quirks.c            | 12 +--------
>  drivers/char/hw_random/omap3-rom-rng.c        | 17 ++++++++++--
>  4 files changed, 49 insertions(+), 13 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/rng/omap3_rom_rng.txt
> 

Acked-by: Rob Herring <robh@xxxxxxxxxx>