Re: [PATCH] firmware: google: increment VPD key_len properly

[Stephen Boyd]

Quoting Brian Norris (2019-09-30 14:45:22)
> Commit 4b708b7b1a2c ("firmware: google: check if size is valid when
> decoding VPD data") adds length checks, but the new vpd_decode_entry()
> function botched the logic -- it adds the key length twice, instead of
> adding the key and value lengths separately.
> 
> On my local system, this means vpd.c's vpd_section_create_attribs() hits
> an error case after the first attribute it parses, since it's no longer
> looking at the correct offset. With this patch, I'm back to seeing all
> the correct attributes in /sys/firmware/vpd/...
> 
> Fixes: 4b708b7b1a2c ("firmware: google: check if size is valid when decoding VPD data")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Cc: Hung-Te Lin <hungte@xxxxxxxxxxxx>
> Cc: Guenter Roeck <groeck@xxxxxxxxxxxx>
> Cc: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>
> ---

Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>