Re: [PATCH v2 linux-next 4/4] arm64: configs: defconfig: Change CONFIG_REMOTEPROC from m to y

[keerthy]

On 10/1/2019 12:16 AM, Olof Johansson wrote:
> On Mon, Sep 30, 2019 at 6:49 AM Will Deacon <will@xxxxxxxxxx> wrote:
> > On Fri, Sep 20, 2019 at 01:29:46PM +0530, Keerthy wrote:
> > > Commit 6334150e9a36 ("remoteproc: don't allow modular build")
> > > changes CONFIG_REMOTEPROC to a boolean from a tristate config
> > > option which inhibits all defconfigs marking CONFIG_REMOTEPROC as
> > > a module in compiling the remoteproc and dependent config options.
> > >
> > > So fix the defconfig to have CONFIG_REMOTEPROC built in.
> > >
> > > Fixes: 6334150e9a36 ("remoteproc: don't allow modular build")
> > > Signed-off-by: Keerthy <j-keerthy@xxxxxx>
> > > ---
> > >   arch/arm64/configs/defconfig | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > > index 8e05c39eab08..c9a867ac32d4 100644
> > > --- a/arch/arm64/configs/defconfig
> > > +++ b/arch/arm64/configs/defconfig
> > > @@ -723,7 +723,7 @@ CONFIG_TEGRA_IOMMU_SMMU=y
> > >   CONFIG_ARM_SMMU=y
> > >   CONFIG_ARM_SMMU_V3=y
> > >   CONFIG_QCOM_IOMMU=y
> > > -CONFIG_REMOTEPROC=m
> > > +CONFIG_REMOTEPROC=y
> > >   CONFIG_QCOM_Q6V5_MSS=m
> > >   CONFIG_QCOM_Q6V5_PAS=m
> > >   CONFIG_QCOM_SYSMON=m
> >
> > Acked-by: Will Deacon <will@xxxxxxxxxx>
> >
> > This fixes the following annoying warning from "make defconfig" on arm64:
> >
> >    arch/arm64/configs/defconfig:726:warning: symbol value 'm' invalid for REMOTEPROC
> >
> > I'm assuming the fix will go via arm-soc, but I can take it otherwise
> > (please just let me know).
>
> Thanks, I'll pick this up, but I'll squash the 4 one-line changes into
> one commit instead of separate patches.

Thanks Olof.

> -Olof