Re: [PATCH] ath9k_hw: fix uninitialized variable data

From: Kalle Valo
Date: Tue Oct 01 2019 - 07:19:15 EST


Denis Efremov <efremov@xxxxxxxxx> wrote:

> Currently, data variable in ar9003_hw_thermo_cal_apply() could be
> uninitialized if ar9300_otp_read_word() will fail to read the value.
> Initialize data variable with 0 to prevent an undefined behavior. This
> will be enough to handle error case when ar9300_otp_read_word() fails.
>
> Fixes: 80fe43f2bbd5 ("ath9k_hw: Read and configure thermocal for AR9462")
> Cc: Rajkumar Manoharan <rmanohar@xxxxxxxxxxxxxxxx>
> Cc: John W. Linville <linville@xxxxxxxxxxxxx>
> Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Denis Efremov <efremov@xxxxxxxxx>
> Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx>

Patch applied to ath-next branch of ath.git, thanks.

80e84f36412e ath9k_hw: fix uninitialized variable data

--
https://patchwork.kernel.org/patch/11163437/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches