Re: [PATCH 2/7] ASoC: amd: Registering device endpoints using MFD framework

[Lee Jones]

On Tue, 01 Oct 2019, vishnu wrote:

> Hi Jones,
> 
> I am very Thankful to your review comments.
> 
> Actually The driver is not totally based on MFD. It just uses 
> mfd_add_hotplug_devices() and mfd_remove_devices() for adding the 
> devices automatically.
> 
> Remaining code has nothing to do with MFD framework.
> 
> So I thought It would not break the coding style and moved ahead by 
> using the MFD API by adding its header file.
> 
> If it is any violation of coding standard then I can move it to 
> drivers/mfd.
> 
> This patch could be a show stopper for us.Please suggest us how can we 
> move ahead ASAP.

Either move the MFD parts to drivers/mfd, or stop using the MFD API.

-- 
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog