Re: [PATCH 0/3] PCI: pciehp: Do not turn off slot if presence comes up after link
From: Stuart Hayes
Date: Wed Oct 02 2019 - 00:31:17 EST
On Tue, Oct 1, 2019 at 11:13 PM Lukas Wunner <lukas@xxxxxxxxx> wrote:
>
> On Tue, Oct 01, 2019 at 05:14:16PM -0400, Stuart Hayes wrote:
> > This patch set is based on a patch set [1] submitted many months ago by
> > Alexandru Gagniuc, who is no longer working on it.
> >
> > [1] https://patchwork.kernel.org/cover/10909167/
> > [v3,0/4] PCI: pciehp: Do not turn off slot if presence comes up after link
>
> If I'm not mistaken, these two are identical to Alex' patches, right?
>
> PCI: pciehp: Add support for disabling in-band presence
> PCI: pciehp: Wait for PDS when in-band presence is disabled
>
> I'm not sure if it's appropriate to change the author and
> omit Alex' Signed-off-by.
>
> Otherwise I have no objections against this series.
>
> Thanks,
>
> Lukas
Thanks! The first patch is identical to the one Alex submitted, and
the second is nearly so... they both basically his work. I wasn't
sure what proper etiquette was--I was thinking the signed-off-by was
taking responsibility that the patch was ok (functional, not
copyrighted by someone else, etc) rather than giving credit, but he
definitely deserves credit for them. I'm happy to add a signed-off-by
for Alex on the first two and resubmit if he doesn't object.