Re: [PATCH v2] i2c: i2c-mt65xx: fix NULL ptr dereference

From: Ulrich Hecht
Date: Wed Oct 02 2019 - 04:50:04 EST



> On September 30, 2019 at 5:28 PM Fabien Parent <fparent@xxxxxxxxxxxx> wrote:
>
>
> Since commit abf4923e97c3 ("i2c: mediatek: disable zero-length transfers
> for mt8183"), there is a NULL pointer dereference for all the SoCs
> that don't have any quirk. mtk_i2c_functionality is not checking that
> the quirks pointer is not NULL before starting to use it.
>
> This commit add a call to i2c_check_quirks which will check whether
> the quirks pointer is set, and if so will check if the IP has the
> NO_ZERO_LEN quirk.
>
> Fixes: abf4923e97c3 ("i2c: mediatek: disable zero-length transfers for mt8183")
> Signed-off-by: Fabien Parent <fparent@xxxxxxxxxxxx>

Thank you! Tested successfully on Acer R13 Chromebook (mt8173).

Tested-by: Ulrich Hecht <uli@xxxxxxxx>

CU
Uli