Re: [PATCH] drm/amdgpu: Drop unused variable and statement

From: Alex Deucher
Date: Wed Oct 02 2019 - 09:39:49 EST


On Wed, Oct 2, 2019 at 3:19 AM Austin Kim <austindh.kim@xxxxxxxxx> wrote:
>
> Even though 'smu8_smu' is declared, it is not used after below statement.
>
> smu8_smu = hwmgr->smu_backend;
>
> So 'unused variable' could be safely removed
> to stop warning message as below:
>
> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/smu8_smumgr.c:180:22:
> warning: variable âsmu8_smuâ set but not used
> [-Wunused-but-set-variable]
>
> struct smu8_smumgr *smu8_smu;
> ^
> Signed-off-by: Austin Kim <austindh.kim@xxxxxxxxx>

Applied. Thanks!

Alex

> ---
> drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c
> index 4728aa2..7dca04a 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c
> @@ -177,12 +177,10 @@ static int smu8_load_mec_firmware(struct pp_hwmgr *hwmgr)
> uint32_t tmp;
> int ret = 0;
> struct cgs_firmware_info info = {0};
> - struct smu8_smumgr *smu8_smu;
>
> if (hwmgr == NULL || hwmgr->device == NULL)
> return -EINVAL;
>
> - smu8_smu = hwmgr->smu_backend;
> ret = cgs_get_firmware_info(hwmgr->device,
> CGS_UCODE_ID_CP_MEC, &info);
>
> --
> 2.6.2
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx