Re: [PATCH] drm/amdgpu: remove set but not used variable 'pipe'

[Alex Deucher]

On Mon, Sep 30, 2019 at 3:03 AM yu kuai <yukuai3@xxxxxxxxxx> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> rivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c: In function
> âamdgpu_gfx_graphics_queue_acquireâ:
> drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:234:16: warning:
> variable âpipeâ set but not used [-Wunused-but-set-variable]
>
> It is never used, so can be removed.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: yu kuai <yukuai3@xxxxxxxxxx>

Applied.  thanks!

Alex

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> index f9bef31..c1035a3 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
> @@ -231,12 +231,10 @@ void amdgpu_gfx_compute_queue_acquire(struct amdgpu_device *adev)
>
>  void amdgpu_gfx_graphics_queue_acquire(struct amdgpu_device *adev)
>  {
> -       int i, queue, pipe, me;
> +       int i, queue, me;
>
>         for (i = 0; i < AMDGPU_MAX_GFX_QUEUES; ++i) {
>                 queue = i % adev->gfx.me.num_queue_per_pipe;
> -               pipe = (i / adev->gfx.me.num_queue_per_pipe)
> -                       % adev->gfx.me.num_pipe_per_me;
>                 me = (i / adev->gfx.me.num_queue_per_pipe)
>                       / adev->gfx.me.num_pipe_per_me;
>
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx