Re: [Xen-devel] [PATCH] x86/xen: Return from panic notifier

From: Boris Ostrovsky
Date: Wed Oct 02 2019 - 10:15:11 EST


On 10/2/19 9:42 AM, Jan Beulich wrote:
>
> I can only guess that the thinking probably was that e.g. external
> dumping (by the tool stack) would be more reliable (including but
> not limited to this meaning less change of state from when the
> original crash reason was detected) than having the domain dump
> itself.


We could register an external dumper (controlled by a boot option
perhaps, off by default) that will call directly into hypervisor with
SHUTDOWN_crash. That will guarantee that we will complete the notifier
chain without relying on priorities. (Of course this still won't address
a possible new feature in panic() that might be called post-dumping)

If you think it's worth doing this can be easily added.

-boris

> True. I guess more control over the behavior needs to be given to
> the admin, as either approach has its up- and downsides
>