Re: [PATCH v1 4/5] staging: fieldbus core: add support for FL-NET devices

[Sven Van Asbroeck]

On Mon, Sep 30, 2019 at 10:09 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Sep 18, 2019 at 02:35:51PM -0400, Sven Van Asbroeck wrote:
> > Add the FL-NET device type to the fieldbus core.
>
> What does this mean?
>
> You add an unspecified enumerated type and suddenly new hardware starts
> working?  That feels really wrong to me...
>

This just empowers fieldbus devices to id themselves as 'flnet' when they
register with the core:

priv->fbdev.fieldbus_type = FIELDBUS_DEV_TYPE_FLNET;
...
err = fieldbus_dev_register(&priv->fbdev);

The core exports this as a sysfs property, so that userspace has a
standardized way of determining the fieldbus type when looking at the
fieldbus dev's sysfs dir.

Yes the commit message is too confusing. I'll write a better one if/when I
repost flnet support. Might be a while because you indicated "no new h/w
support while still in staging".