Re: [PATCH v3] rtc: wilco-ec: Handle reading invalid times
From: Alexandre Belloni
Date: Wed Oct 02 2019 - 11:34:15 EST
On 02/10/2019 08:20:34-0700, Dmitry Torokhov wrote:
> > I'm still not convinced it is useful to have an error in dmesg when the
> > time is invalid, as long as userspace knows it is invalid. What is the
> > course of action for the end user when that happens?
>
> Report it, or, in our case, we will see it in the feedback logs.
> However I do agree that it is not the best option, even if we report
> error to userspace I am not sure if it will handle it properly. What
> userspace is supposed to do when presented with -EIO or similar?
>
I would say probably retry a few times if it gets -EIO and simply abort
in case of -EINVAL. I'm not aware of any userspace tool behaving that
way though. They all simply abort.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com